[PATCH] D12713: Runtime test for poisoning vtable pointer during destruction.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 12:54:21 PDT 2015


eugenis added a comment.

The description says "just before returning from base destructor" - is it true? I though it would be the complete destructor.


================
Comment at: test/msan/dtor-multiple-inheritance.cc:29
@@ -30,2 +28,3 @@
     assert(__msan_test_shadow(&this->x, sizeof(this->x) == -1));
+    assert(__msan_test_shadow(temp_x, sizeof(*temp_x)) == -1);
     // bad access subclass member
----------------
These two lines check the same thing, one can be removed. The same in multiple places below.


http://reviews.llvm.org/D12713





More information about the llvm-commits mailing list