[PATCH] D12713: Explicit reference to issue.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 11:26:29 PDT 2015


eugenis added a comment.

Please update the revision title and description to reflect its contents.


================
Comment at: test/msan/dtor-multiple-inheritance.cc:89
@@ +88,3 @@
+  // Keep track of members inherited from virtual bases,
+  // since the virtula base table is inaccessible after destruction.
+  int *temp_x = &d->x;
----------------
typo

================
Comment at: test/msan/dtor-multiple-inheritance.cc:95
@@ +94,3 @@
+  int **temp_z_ptr = &d->z_ptr;
+  int **temp_w_ptr = &d->w_ptr;
+
----------------
Maybe it would be easier to make these pointers global and use them in the various destructors to get rid of all the *_ptr members, and set_ptrs code. This would make the test almost 2x shorter.



http://reviews.llvm.org/D12713





More information about the llvm-commits mailing list