[PATCH] D12499: Replace ScalarEvolution based domain generation

Johannes Doerfert via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 07:23:32 PDT 2015


jdoerfert marked 2 inline comments as done.

================
Comment at: lib/Support/SCEVValidator.cpp:357
@@ +356,3 @@
+    return ValidatorResult(SCEVType::INVALID);
+    /*
+        assert(SRem->getOpcode() == Instruction::SRem &&
----------------
grosser wrote:
> Interesting. I do not care so much about loop bounds/conditions, but it would be sad to loose support even in array index expressions. To my understanding, srem instructions in index expressions should not cause troubles in our domain generation algorithm, no?
Correct. Any ideas on how to allow those but forbid srem in domain related expressions?


http://reviews.llvm.org/D12499





More information about the llvm-commits mailing list