[PATCH][Solaris] Use the GCC Installation detector to add the C++ include paths

Rafael Espíndola via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 9 06:39:07 PDT 2015


r247144.

You are doing quite a bit of work for supporting Solaris. You should
probably try to get commit access.

Cheers,
Rafael


On 4 September 2015 at 04:14, Xan López <xan at igalia.com> wrote:
> On Wed, Aug 26, 2015 at 10:28:52AM -0400, Rafael Espíndola wrote:
>> LGTM
>
> Thanks! Can you commit the patch for me?
>
> Xan
>
>>
>> On 17 August 2015 at 06:16, Xan López <xan at igalia.com> wrote:
>> > Hi Yaron, Rafael,
>> >
>> > thanks, I updated the patch with a test. Please note I'm using the
>> > testing ifrastructure already created in a previous patch Rafael
>> > reviewed once (that's why the sysroot is not created, among other
>> > things).
>> >
>> > Patch attached.
>> >
>> > On Wed, Aug 05, 2015 at 04:54:28PM +0300, Yaron Keren wrote:
>> >> I made similar test for mingw toolchain in clang/test/Driver/mingw.cpp :
>> >> create a directory structure under Inputs, direct clang to it using
>> >> --sysroot and test that the expected directories are found.
>> >>
>> >>
>> >>
>> >> 2015-08-05 16:15 GMT+03:00 Rafael Espíndola <rafael.espindola at gmail.com>:
>> >>
>> >> > This looks ok, but can you add a testcase?
>> >> >
>> >> > On 28 July 2015 at 06:20, Xan López <xan at igalia.com> wrote:
>> >> > > A follow up to the previous patch, this gets rid of the last hardcoded
>> >> > > path (and moves it to its proper place).
>> >> > >
>> >> > > _______________________________________________
>> >> > > llvm-commits mailing list
>> >> > > llvm-commits at cs.uiuc.edu
>> >> > > http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> >> > >
>> >> > _______________________________________________
>> >> > llvm-commits mailing list
>> >> > llvm-commits at lists.llvm.org
>> >> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> >> >


More information about the llvm-commits mailing list