[PATCH] D12713: Explicit reference to issue.

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: test/msan/dtor-vtable.cc:1
@@ -1,2 +1,2 @@
 // RUN: %clangxx_msan %s -O0 -fsanitize=memory -fsanitize-memory-use-after-dtor -o %t && MSAN_OPTIONS=poison_in_dtor=1 %run %t >%t.out 2>&1
 
----------------
No need for >%t.out 2>&1

================
Comment at: test/msan/dtor-vtable.cc:16
@@ +15,3 @@
+  int x;
+  virtual ~A() {}
+  virtual void A_Foo() {}
----------------
The destructor does not have to be virtual.

================
Comment at: test/msan/dtor-vtable.cc:21
@@ -29,9 +20,3 @@
 int main() {
-  NonTrivial *nt = new NonTrivial();
-  nt->~NonTrivial();
-  assert(__msan_test_shadow(nt, sizeof(*nt)) != -1);
-
-  Trivial *t = new Trivial();
-  t->~Trivial();
-  assert(__msan_test_shadow(t, sizeof(*t)) != -1);
-
+  // Get pointer to virtual function in base class
+  A *a = new A();
----------------
this comment looks out-of-date


http://reviews.llvm.org/D12713