[PATCH] D9067: LiveIntervalAnalysis: Support moving of subregister defs in handleMove

[Matthias Braun via llvm-commits]

MatzeB added a comment.

In http://reviews.llvm.org/D9067#242052, @qcolombet wrote:

> Hi Matthias,
>
> You mentioned that you found and fixed several regressions. Yet, this patch does not have any test cases added. Am I correctly assuming this is because the related test cases are already in the repository?
>  If not, could you please add them.
>
> You also have a couple of missing period at the end of the comments. I’ve highlighted the first few ones. Please double check.
>
> The patch mostly LGTM, though the comments would benefits from more examples (like you did with “ where I = [xi…”). Please double check the potential overlapping issue I pointed out.
>
> Thanks,
> -Quentin


This patch was part of a series of 4 related changes (see dependencies). This patch alone does not regress anything but simply introduces new capabilities to handleMove(). All patches combined regressed some existing testcases so no need for additional ones. Anyway I plan to only commit this change after the other 3 patches are reworked.


Repository:
  rL LLVM

http://reviews.llvm.org/D9067