[PATCH] D12656: PR 23155: Change test to allow movzbl, movzwl in place of movb, movw instructions

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 17:04:57 PDT 2015


qcolombet added a comment.

Hi,

I agree with Sanjay that we shouldn’t add variability here.
Either we have a clear flag to choose one of the variants or we stick to just one.

Yes, both variants are correct here, but generating one or the other without being aware that another commit changes it sounds worrisome to me.

Cheers,
-Quentin


http://reviews.llvm.org/D12656





More information about the llvm-commits mailing list