[PATCH] D12346: x32. Fixes a bug in how struct va_list is initialized in x32

Tue Sep 8 10:27:04 PDT 2015

dschuff added a comment.

Just noticed one other thing


================
Comment at: test/CodeGen/X86/nosse-varargs.ll:6
@@ -3,3 +5,3 @@
 ; PR3403
 target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128"
 target triple = "x86_64-unknown-linux-gnu"
----------------
x32 has a different datalayout than x86-64, and there seems to be some 64-bit pointer assumptions baked into this bitcode. Maybe we should regenerate/modify this in a separate test for x32. (the same maybe applies to stdarg.ll although it looks like the gep operands are the only thing theres, so maybe that's OK)


http://reviews.llvm.org/D12346



