[PATCH] D10674: Value profiling - patchset 3

[Betul Buyukkurt via llvm-commits]

Ping?

 

-----Original Message-----
From: Betul Buyukkurt [mailto:betulb at codeaurora.org] 
Sent: Thursday, September 03, 2015 12:39 PM
To: betulb at codeaurora.org; mail at justinbogner.com; dnovillo at google.com; dsule at codeaurora.org; davidxl at google.com; ibaev at codeaurora.org
Cc: llvm-commits at lists.llvm.org
Subject: Re: [PATCH] D10674: Value profiling - patchset 3

                       

betulb updated this revision to Diff 33963.

betulb added a comment.

 

In this revision:

 

- Turned the error to assert for "hash value not matching any known key"

- Used rvalue-reference semantics when passing arguments into the InstrProfWriter's addRecord routine. String table usage caused the undesirable removal of const qualifier from addRecord's argument. Now the arguments to addRecord are clearly passed using std::move()

- In combineInstrProfRecords, tried to account for when value profiling is not enabled for a given kind for Source vs enabled for Dest and vice versa.

- Used std::vector's empty() instead of comparing size() against 0

 

 

 <http://reviews.llvm.org/D10674> http://reviews.llvm.org/D10674

 

Files:

  include/llvm/ProfileData/InstrProf.h

  include/llvm/ProfileData/InstrProfReader.h

  include/llvm/ProfileData/InstrProfWriter.h

  lib/ProfileData/InstrProf.cpp

  lib/ProfileData/InstrProfIndexed.h

  lib/ProfileData/InstrProfReader.cpp

  lib/ProfileData/InstrProfWriter.cpp

  tools/llvm-profdata/llvm-profdata.cpp

  unittests/ProfileData/CoverageMappingTest.cpp

  unittests/ProfileData/InstrProfTest.cpp

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150908/cfb6d7c7/attachment.html>