[PATCH] D11890: Fixed Visual Studio warnings.

Yaron Keren via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 8 07:20:44 PDT 2015

yaron.keren added a subscriber: stoklund.
yaron.keren added a comment.

The asserts on unit tests, BitVectorTest/1.PortableBitMask that calls

  TypeParam A;
  const uint32_t Mask1[] = { 0x80000000, 6, 5 };
  A.setBitsInMask(Mask1, 3);

Now setBitsInMask is documented:

  /// setBitsInMask - Add '1' bits from Mask to this vector. Don't resize.
  /// This computes "*this |= Mask".

and it can not | a small bit vector with a 3x32 bit mask without resizing. It is an error which should not go silent and the test should be modified.

Jakob, do we miss something?


More information about the llvm-commits mailing list