[PATCH] D12590: [cmake] rework LLVM_LINK_LLVM_DYLIB option handling

[Andrew Wilkins via llvm-commits]

axw marked an inline comment as done.
axw added a comment.

Thanks for the review.


================
Comment at: cmake/modules/LLVM-Config.cmake:45
@@ -35,1 +44,3 @@
+
+  explicit_llvm_config(${executable} ${link_components})
 endmacro(llvm_config)
----------------
beanz wrote:
> I do think we should strip out the components based on `LLVM_DYLIB_COMPONENTS` to make it more explicit, but this is fine, we can do that later.
I've added a TODO. The main complication is in handling the case of LLVM_DYLIB_COMPONETS=all. I think it just means ~replicating what's done in llvm-shlib: convert all to libnames and only retain the shared library ones, which won't be included in libLLVM.


http://reviews.llvm.org/D12590