[llvm] r243956 - [SDAG] Fix a result chain in ExpandUnalignedLoad

Hans Wennborg via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 4 08:12:05 PDT 2015


I've put this on my list for when Tom starts the 3.7.1 process.

Thanks,
Hans

On Wed, Sep 2, 2015 at 6:18 PM, Quentin Colombet <qcolombet at apple.com> wrote:
> This time with the right list in CC!
>
>> On Sep 2, 2015, at 6:17 PM, Quentin Colombet <qcolombet at apple.com> wrote:
>>
>> Hi Hans,
>>
>> Could we pull that on the release branch?
>> That would fix PR24669.
>> https://llvm.org/bugs/show_bug.cgi?id=24669
>>
>> Cheers,
>> -Quentin
>>> On Aug 3, 2015, at 11:29 PM, Hal Finkel <hfinkel at anl.gov> wrote:
>>>
>>> Author: hfinkel
>>> Date: Tue Aug  4 01:29:12 2015
>>> New Revision: 243956
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=243956&view=rev
>>> Log:
>>> [SDAG] Fix a result chain in ExpandUnalignedLoad
>>>
>>> On the code path in ExpandUnalignedLoad which expands an unaligned vector/fp
>>> value in terms of a legal integer load of the same size, the ChainResult needs
>>> to be the chain result of the integer load.
>>>
>>> No in-tree test case is currently available.
>>>
>>> Patch by Jan Hranac!
>>>
>>> Modified:
>>>   llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
>>>
>>> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp
>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp?rev=243956&r1=243955&r2=243956&view=diff
>>> ==============================================================================
>>> --- llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp (original)
>>> +++ llvm/trunk/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp Tue Aug  4 01:29:12 2015
>>> @@ -439,7 +439,7 @@ ExpandUnalignedLoad(LoadSDNode *LD, Sele
>>>                             ISD::ANY_EXTEND, dl, VT, Result);
>>>
>>>      ValResult = Result;
>>> -      ChainResult = Chain;
>>> +      ChainResult = newLoad.getValue(1);
>>>      return;
>>>    }
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>>
>


More information about the llvm-commits mailing list