[llvm] r246812 - [IR] Have AttrBuilder::clear clear `TargetDepAttrs`.

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 3 15:27:42 PDT 2015


Author: sanjoy
Date: Thu Sep  3 17:27:42 2015
New Revision: 246812

URL: http://llvm.org/viewvc/llvm-project?rev=246812&view=rev
Log:
[IR] Have AttrBuilder::clear clear `TargetDepAttrs`.

Test case attached -- currently the parser smears the "foo bar" to all
of the formal arguments.

Added:
    llvm/trunk/test/Assembler/incorrect-tdep-attrs-parsing.ll
Modified:
    llvm/trunk/lib/IR/Attributes.cpp

Modified: llvm/trunk/lib/IR/Attributes.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Attributes.cpp?rev=246812&r1=246811&r2=246812&view=diff
==============================================================================
--- llvm/trunk/lib/IR/Attributes.cpp (original)
+++ llvm/trunk/lib/IR/Attributes.cpp Thu Sep  3 17:27:42 2015
@@ -1108,6 +1108,7 @@ AttrBuilder::AttrBuilder(AttributeSet AS
 
 void AttrBuilder::clear() {
   Attrs.reset();
+  TargetDepAttrs.clear();
   Alignment = StackAlignment = DerefBytes = DerefOrNullBytes = 0;
 }
 

Added: llvm/trunk/test/Assembler/incorrect-tdep-attrs-parsing.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Assembler/incorrect-tdep-attrs-parsing.ll?rev=246812&view=auto
==============================================================================
--- llvm/trunk/test/Assembler/incorrect-tdep-attrs-parsing.ll (added)
+++ llvm/trunk/test/Assembler/incorrect-tdep-attrs-parsing.ll Thu Sep  3 17:27:42 2015
@@ -0,0 +1,6 @@
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
+
+; CHECK: define i32 @f(i64 "foo bar", i64, i64, i64 "xyz") {
+define i32 @f(i64 "foo bar", i64, i64, i64 "xyz") {
+  ret i32 41
+}




More information about the llvm-commits mailing list