[PATCH] D11931: AVX512 : vplzcnt and vpconflict implemantation

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 23:19:24 PDT 2015


delena added inline comments.

================
Comment at: include/llvm/IR/IntrinsicsX86.td:5565
@@ -5564,2 +5564,3 @@
 // AVX-512 conflict detection
+//         count the number of leading zero bits
 let TargetPrefix = "x86" in {
----------------
// AVX-512 conflict detection instructions
// Instructions that count the number of leading zero bits

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:1484
@@ -1483,1 +1483,3 @@
     }
+    if (Subtarget->hasVLX() && Subtarget->hasCDI()) {
+      setOperationAction(ISD::CTLZ,             MVT::v4i64, Legal);
----------------
You should add a test that checks this. 

================
Comment at: test/CodeGen/X86/avx512cdvl-intrinsics.ll:190
@@ +189,3 @@
+}
+
+
----------------
remove empty lines


Repository:
  rL LLVM

http://reviews.llvm.org/D11931





More information about the llvm-commits mailing list