[PATCH] D12545: [elf2] Add basic archive file support.

[Rafael Espíndola via llvm-commits]

Why use a llvm::MallocAllocator? It seems better to not have an
allocator and use a smart pointer or use a BumpPtrAllocator.

Given that the allocator is used for exactly one allocation per file,
wouldn't it be the same to replace

  std::vector<Lazy *> LazySymbols;
  llvm::MallocAllocator Alloc;

With

  std::vector<Lazy> LazySymbols
?

On 2 September 2015 at 11:33, Rafael Ávila de Espíndola
<llvm-commits at lists.llvm.org> wrote:
> rafael added inline comments.
>
> ================
> Comment at: ELF/InputFiles.cpp:15
> @@ -14,2 +14,3 @@
>  #include "llvm/ADT/STLExtras.h"
> +#include "llvm/Support/FileSystem.h"
>
> ----------------
> Not used.
>
>
> http://reviews.llvm.org/D12545
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits