[PATCH] D12543: [x86] fix allowsMisalignedMemoryAccesses() for 8-byte and smaller accesses

Zia Ansari via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 2 08:37:59 PDT 2015


zansari added a comment.

lgtm..

The overlapping is interesting.. With a 0 mod 16 rsp, if we didn't overlap, we would split a cache line. At a high level, it looks like it's a reasonable strategy (without knowing all the cases in which it'll trigger). The extra immediate generation is, however, weird.

Thanks,
Zia.


http://reviews.llvm.org/D12543





More information about the llvm-commits mailing list