[lld] r246537 - COFF: .exe files should be able to export functions.

[Rui Ueyama via llvm-commits]

Yes it is. Ed Maste kindly submitted the change for me in r246559.

On Wed, Sep 2, 2015 at 1:27 AM, Rafael Espíndola <rafael.espindola at gmail.com
> wrote:

> I think it is just missing a
>
> REQUIRES: winlib
>
> On 1 September 2015 at 12:09, Davide Italiano via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > On Tue, Sep 1, 2015 at 2:15 AM, Rui Ueyama via llvm-commits
> > <llvm-commits at lists.llvm.org> wrote:
> >> Author: ruiu
> >> Date: Tue Sep  1 04:15:58 2015
> >> New Revision: 246537
> >>
> >> URL: http://llvm.org/viewvc/llvm-project?rev=246537&view=rev
> >> Log:
> >> COFF: .exe files should be able to export functions.
> >>
> >> In r246424, I made a change that disables non-DLL to export
> >> symbols. It turned out that the change was not correct. Both
> >> DLLs and executables are able to export symbols (although the
> >> latter is relatively rare). This change restores the feature.
> >>
> >
> >
> > Hi Rui,
> > not sure if it's my fault of yours, but it seems this breaks test
> > suite on FreeBSD.
> > Can you please take a look?
> >
> >
> > FAIL: lld :: COFF/export-exe.test (24 of 826)
> > ******************** TEST 'lld :: COFF/export-exe.test' FAILED
> > ********************
> > Script:
> > --
> > lld-link /entry:main
> > /out:/exps/llvm2/build/tools/lld/test/COFF/Output/export-exe.test.tmp.exe
> > /subsystem:windows    /exps/llvm2/tools/lld/test/COFF/Inputs/ret42.obj
> > /export:main
> > llvm-objdump -p
> > /exps/llvm2/build/tools/lld/test/COFF/Output/export-exe.test.tmp.exe |
> > FileCheck /exps/llvm2/tools/lld/test/COFF/export-exe.test
> > --
> > Exit Code: 1
> >
> > Command Output (stderr):
> > --
> > unable to find lib.exe in PATH: : No such file or directory
> >
> > --
> > Davide
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150902/075e270a/attachment.html>