[PATCH] Devirtualize TerminatorInst

[Pete Cooper via llvm-commits]

Makes sense.  Here’s an updated patch.

Pete


> On Sep 1, 2015, at 3:48 PM, David Majnemer <david.majnemer at gmail.com> wrote:
> 
> Isn't it a little bit of a misnomer to continue to call it 'getSuccessorV', etc.?  IMO, something like getSuccessorImpl would be more fitting.
> 
> On Tue, Sep 1, 2015 at 3:41 PM, Pete Cooper via llvm-commits <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
> Hi Duncan, David
> 
> I took a break from devirtualizing Value as David raised performance concerns I wanted to check before continuing.
> 
> The original series of patches and discussion were around here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20150622/282810.html <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_pipermail_llvm-2Dcommits_Week-2Dof-2DMon-2D20150622_282810.html&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BerEYhiaI1GmCI3aHR4i5-TzETn6EKLF00_njq3c5KA&s=ZsfrT-MHZJfbR_OMkIT0H57JCJDsgZOt-aPLkTpzri4&e=>
> 
> This is what was patch 0005 in that series, but updated now that we have additional TerminatorInst’s since then.
> 
> I ran our performance suite here and there were no regressions.  It actually slightly improved (about 2-3%) MultiSource/Benchmarks/TSVC/ControlLoops-dbl/ControlLoops-dbl.
> 
> Assuming this patch lands ok, i’ll continue with the same testing methodology for the remainder of the series.
> 
> Cheers,
> Pete
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits <https://urldefense.proofpoint.com/v2/url?u=http-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=BQMFaQ&c=eEvniauFctOgLOKGJOplqw&r=03tkj3107244TlY4t3_hEgkDY-UG6gKwwK0wOUS3qjM&m=BerEYhiaI1GmCI3aHR4i5-TzETn6EKLF00_njq3c5KA&s=EGd8eoHXQo7uNGXzUN8vZJ3UK9To1OOz9nrm7uYCE9c&e=>
> 
> 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150901/e6392d17/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: devirt-TerminatorInst.patch
Type: application/octet-stream
Size: 17524 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150901/e6392d17/attachment.obj>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150901/e6392d17/attachment-0001.html>