[PATCH] D12533: [WinEH] Add llvm.eh.padparam intrinsic

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 13:21:11 PDT 2015


rnk added a comment.

In http://reviews.llvm.org/D12533#237559, @JosephTremoulet wrote:

> > How about making it `llvm_any_ty` and using `i8 addressspace(1) * @llvm.eh.exceptionpointer.p1i8(token)`?
>
>
> I can do something along those lines, sure.  Two questions:
>
> 1. If it's always going to be a pointer type, would it be better to use `llvm_anyptr_ty` and `i8 addrspace(1)* @llvm.eh.exceptionpointer.p1(token)`?


Sounds good.

> 2. OTOH, if it's not always going to be a pointer type (e.g. if you're going to use the same one for SEH exception codes), should the name be something like `llvm.eh.get_exception` that doesn't include `pointer`?


If/when we add SEH filter funclets, we'll need separate constructs for __exception_info() and __exception_code(). In anticipation, we should probably use `llvm.eh.exceptioncode` for the SEH code.


http://reviews.llvm.org/D12533





More information about the llvm-commits mailing list