[PATCH] D12480: [LV] Delay predication of stores until near the end of vector code generation

James Molloy via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 1 13:18:55 PDT 2015


Hi,

I was in two minds about this. I thought like you did originally, but I
ended up deciding that trying to get the extractelements inside the
predicated blocks would be a false economy. Sinking those extracts is
something InstCombine or similar should do trivially (in fact, that would
be a good test - I'll add that).

James

On Tue, 1 Sep 2015 at 20:30 Michael Zolotukhin via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> mzolotukhin added a comment.
>
> Hi James,
>
> While the general idea looks appealing to me, I'm worried on the changes
> that we have in the test. It looks like we increased loop's critical path
> length by this change by moving `extractelement` up from branches. What
> would it take to change it back?
>
> Thanks,
> Michael
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D12480
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150901/04dc2ebb/attachment.html>


More information about the llvm-commits mailing list