[PATCH] D12308: gold-plugin: Implement parallel LTO code generation using llvm::LinkedCodeGen.

[Peter Collingbourne via llvm-commits]

pcc added a comment.

In http://reviews.llvm.org/D12308#237283, @rafael wrote:

> Needs a testcase. Do include one test using save-temps or obj-path showing the mulitple .o files that are created.


This would be `test/tools/gold/X86/parallel.ll`, no?


================
Comment at: tools/gold/gold-plugin.cpp:108
@@ -105,4 +107,3 @@
 
-  static void process_plugin_option(const char *opt_)
-  {
+  static bool process_plugin_option(const char *opt_) {
     if (opt_ == nullptr)
----------------
rafael wrote:
> Why do you need to change this? All the errors in here still fail the build, no?
I suppose it doesn't really matter much, but I think it is more appropriate to use the linker callbacks here rather than `report_fatal_error` which should only really be used for LLVM internal errors.


http://reviews.llvm.org/D12308