[PATCH] D10674: Value profiling - patchset 3

[Xinliang David Li via llvm-commits]

Justin, do you have any more concerns?

thanks,

David

On Sat, Aug 29, 2015 at 11:03 AM, David Li <davidxl at google.com> wrote:
> davidxl added a comment.
>
> This version looks fine to me.
>
>
> ================
> Comment at: lib/ProfileData/InstrProfReader.cpp:341
> @@ +340,3 @@
> +        uint64_t NumTaken = endian::readNext<uint64_t, little, unaligned>(D);
> +        if (ValueKind == instrprof_value_kind::indirect_call_target) {
> +          auto Result = HashKeyMap.find(Value);
> ----------------
> Make it into an assert for now.
>
>
> http://reviews.llvm.org/D10674
>
>
>