[llvm] r246491 - Revert "[lit] Speculatively fix PR24554 by manually closing the process handle"

[NAKAMURA Takumi via llvm-commits]

Regarding the failure log, neither lit nor python would be culprit, I guess.
I supposed r245946 tried to resolve indirection issues.

We'd need to implement "retry" for win32.

On Tue, Sep 1, 2015 at 2:15 PM Reid Kleckner <rnk at google.com> wrote:

> Right, r245946 was an attempt to fix the problem in asan tests, but it
> didn't seem to work.
>
> Given that it didn't work and it uses private details of subprocess.Popen,
> I'd rather take it back out and try to understand the real cause of the
> problem.
>
> On Mon, Aug 31, 2015 at 5:49 PM, NAKAMURA Takumi <geek4civic at gmail.com>
> wrote:
>
>> The failure in asan is nothing to do with r245946, I guess.
>> I think r245946 was reasonable (better than nothing).
>>
>>
>>
>> On Tue, Sep 1, 2015 at 6:43 AM Reid Kleckner via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> Author: rnk
>>> Date: Mon Aug 31 16:42:02 2015
>>> New Revision: 246491
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=246491&view=rev
>>> Log:
>>> Revert "[lit] Speculatively fix PR24554 by manually closing the process
>>> handle"
>>>
>>> This reverts commit r245946. It didn't help the problem:
>>>
>>> http://lab.llvm.org:8011/builders/sanitizer-windows/builds/9179/steps/run%20tests/logs/stdio
>>> LINK : fatal error LNK1104: cannot open file
>>>
>>> Modified:
>>>     llvm/trunk/utils/lit/lit/TestRunner.py
>>>
>>> Modified: llvm/trunk/utils/lit/lit/TestRunner.py
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=246491&r1=246490&r2=246491&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/utils/lit/lit/TestRunner.py (original)
>>> +++ llvm/trunk/utils/lit/lit/TestRunner.py Mon Aug 31 16:42:02 2015
>>> @@ -257,9 +257,6 @@ def executeShCmd(cmd, shenv, results):
>>>      exitCode = None
>>>      for i,(out,err) in enumerate(procData):
>>>          res = procs[i].wait()
>>> -        # On Windows, manually close the process handles.
>>> -        if kIsWindows:
>>> -            procs[i]._handle.Close()
>>>          # Detect Ctrl-C in subprocess.
>>>          if res == -signal.SIGINT:
>>>              raise KeyboardInterrupt
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150901/a500b7a1/attachment.html>