[PATCH] D12488: Enable linking tools, shared libraries against libLLVM

[NAKAMURA Takumi via llvm-commits]

chapuni added inline comments.

================
Comment at: cmake/modules/AddLLVM.cmake:44
@@ -43,3 +43,3 @@
   #   - PROPERTY COMPILE_FLAGS is string.
-  string(REPLACE ";" " " target_compile_flags "${LLVM_COMPILE_FLAGS}")
+  string(REPLACE ";" " " target_compile_flags " ${LLVM_COMPILE_FLAGS}")
 
----------------
Is it relevant to your changes?
FYI, it triggers recompilation of whole files (on ninja).

================
Comment at: cmake/modules/TableGen.cmake:74
@@ -73,3 +73,3 @@
 macro(add_tablegen target project)
   set(${target}_OLD_LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS})
   set(LLVM_LINK_COMPONENTS ${LLVM_LINK_COMPONENTS} TableGen)
----------------
I thought it'd be just a variable, not an option, IMO.

The name "DISABLE_LLVM_LINK_LLVM_DYLIB" may be shorten.


http://reviews.llvm.org/D12488