[PATCH] D12418: Distribute the weight on the edge from switch to default statement to edges generated in lowering switch.

[Cong Hou via llvm-commits]

congh marked an inline comment as done.
congh added a comment.

Thanks for the review, Hans!


================
Comment at: test/CodeGen/X86/switch-edge-weight.ll:60
@@ +59,3 @@
+
+; This switch statement will be translated into range checks.
+
----------------
hans wrote:
> The switch has four clusters though, so it becomes a binary tree with range checks in the leafs, just like @test above. Is this one testing something that @test doesn't?
In this switch statement there are two jump targets instead of 1 in @test. However, I found they are still testing the same thing so I will go ahead and delete this test. Thanks for  pointing it out!

================
Comment at: test/CodeGen/X86/switch-edge-weight.ll:115
@@ +114,3 @@
+; In this switch statement, there is an edge from jump table to default
+; statement.
+
----------------
hans wrote:
> s/statement/basic block/
OK.


http://reviews.llvm.org/D12418