[PATCH] D12442: MachineBasicBlock: Save LaneMask with livein registers.

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 16:58:22 PDT 2015


qcolombet added inline comments.

================
Comment at: lib/CodeGen/MachineBasicBlock.cpp:327
@@ -323,2 +326,3 @@
 
 void MachineBasicBlock::removeLiveIn(MCPhysReg Reg) {
+  LiveInVector::iterator I = std::find_if(
----------------
In theory, we could remove just a sub register of an existing live range.
Shouldn’t this API take a LaneMask as well?

================
Comment at: lib/CodeGen/MachineBasicBlock.cpp:335
@@ -329,2 +334,3 @@
 
 bool MachineBasicBlock::isLiveIn(MCPhysReg Reg) const {
+  livein_iterator I = std::find_if(
----------------
Ditto.
We may want to query just a given lane, don’t we?


Repository:
  rL LLVM

http://reviews.llvm.org/D12442





More information about the llvm-commits mailing list