[PATCH] D11847: [BasicAA] Fix zext & sext handling

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 15:34:54 PDT 2015


> On Aug 31, 2015, at 3:04 PM, Quentin Colombet via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Hi Nick,
> 
> I was looking into why this patch was introducing other problems and I think it boils down to I’ve screwed up my rebase of this patch.
> Doing it again from scratch (after reverting my revert r245394) seems to yield correct code.
> 
> I am going to push your changes.
> 
> I let you know which revision it is so that you can double check that I did not screw up again!

This landed in Committed revision 246502.

Q.
> 
> Thanks,
> -Quentin
> 
> 
>> On Aug 19, 2015, at 2:12 PM, Nicholas White <n.j.white at gmail.com> wrote:
>> 
>> Hi - sorry I haven't had time to address Hal's review comments yet,
>> and thanks for the additional test case Quentin. This patch (or as you
>> pointed out, series of edits to the sext / zext code) is only intended
>> to fix outstanding bugs, not add any new functionality. It'd be good
>> if this gets into 3.7 but the bugs it fixes are in the 3.6 release and
>> aren't causing too much pain - and touching this part of the codebase
>> has a lot of downstream consequences. Thanks -
>> 
>> Nick
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150831/aa8a46aa/attachment-0001.html>


More information about the llvm-commits mailing list