[PATCH] D12338: Add a boolean parameter to make the initial load atomic.

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 10:09:38 PDT 2015


jfb added inline comments.

================
Comment at: test/Transforms/AtomicExpand/X86/expand-atomic-rmw-initial-load.ll:7
@@ -6,3 +6,3 @@
 define i8 @test_initial_load(i8* %ptr, i8 %value) {
   %res = atomicrmw nand i8* %ptr, i8 %value seq_cst
   ret i8 %res
----------------
Could you also test the other memory orderings in separate test functions? I mainly want to ensure that an `acq_rel` RMW operation gets a `load acquire` (the others should have the same ordering).


http://reviews.llvm.org/D12338





More information about the llvm-commits mailing list