[PATCH] D12488: Enable linking tools, shared libraries against libLLVM

Andrew Wilkins via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 31 02:27:45 PDT 2015


axw added a comment.

In http://reviews.llvm.org/D12488#236244, @pcc wrote:

> > Without these changes, passes won't load because the "Annotate..." symbols defined in lib/Support/Valigrind.cpp are not found.
>
>
> I haven't looked at this in detail yet, but are these changes necessary after r245374?


Argh! :)

Probably not. Is there any strong reason *not* to change it now? This way, if later on someone adds weak symbols or others that don't begin with/include LLVM/llvm, then they'll get picked up.


http://reviews.llvm.org/D12488





More information about the llvm-commits mailing list