[llvm] r246344 - Use UNSUPPORTED instead of XFAIL to disable this test, as it passes on one AArch64 bot.

Yaron Keren via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 30 15:06:32 PDT 2015


Hi Peter,

llvm::splitCodeGen() in lib/CodeGen/ParallelCG.cpp (called from this test)
uses threads even when LLVM was compiled without thread
support, LLVM_ENABLE_THREADS=0. This does not end well.

As long as LLVM_ENABLE_THREADS=0 is supported build option (should it go
away?) the code should not use threads (and thus the test will pass). Maybe
limit -j to 1 and run everything on the main thread without creating any
threads?

Yaron





2015-08-29 1:17 GMT+03:00 Peter Collingbourne via llvm-commits <
llvm-commits at lists.llvm.org>:

> Author: pcc
> Date: Fri Aug 28 17:17:29 2015
> New Revision: 246344
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246344&view=rev
> Log:
> Use UNSUPPORTED instead of XFAIL to disable this test, as it passes on one
> AArch64 bot.
>
> Modified:
>     llvm/trunk/test/LTO/X86/parallel.ll
>
> Modified: llvm/trunk/test/LTO/X86/parallel.ll
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/LTO/X86/parallel.ll?rev=246344&r1=246343&r2=246344&view=diff
>
> ==============================================================================
> --- llvm/trunk/test/LTO/X86/parallel.ll (original)
> +++ llvm/trunk/test/LTO/X86/parallel.ll Fri Aug 28 17:17:29 2015
> @@ -4,7 +4,7 @@
>  ; RUN: llvm-nm %t.o.1 | FileCheck --check-prefix=CHECK1 %s
>
>  ; FIXME: Investigate test failures on these architecures.
> -; XFAIL: mips, mipsel, aarch64
> +; UNSUPPORTED: mips, mipsel, aarch64
>
>  target triple = "x86_64-unknown-linux-gnu"
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150831/332d2519/attachment.html>


More information about the llvm-commits mailing list