[PATCH] D12479: [X86][AVX512BW] support in byte shift and SAD

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 30 04:58:56 PDT 2015


delena added inline comments.

================
Comment at: ../llvmTmp/lib/Target/X86/X86InstrAVX512.td:6788
@@ +6787,3 @@
+             !strconcat(OpcodeStr, "\t{$src2, $src1, $dst|$dst, $src1, $src2}"),
+             [(set _.RC:$dst,(_.VT (OpNode _.RC:$src1, (i32 imm:$src2))))]>;
+  let mayLoad = 1 in
----------------
While DAG lowering, we build SHIFT nodes with Imm8. I suppose that Imm32 will not work in this case.
Could you, please, add IR tests for these nodes?


http://reviews.llvm.org/D12479





More information about the llvm-commits mailing list