[llvm] r246367 - [Triple] Stop abusing a class to have only static methods and just use

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 30 03:13:07 PDT 2015


On 30 August 2015 at 03:09, Chandler Carruth via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: chandlerc
> Date: Sat Aug 29 21:09:48 2015
> New Revision: 246367
>
> URL: http://llvm.org/viewvc/llvm-project?rev=246367&view=rev
> Log:
> [Triple] Stop abusing a class to have only static methods and just use
> the namespace that we are already using for the enums that are produced
> by the parsing.

Hi Chandler,

So, about this one, I wish you had asked first.

This is a big mess, yes, but the answer is not that simple. It did
occur to me to do it like that from the beginning, you'd be glad to
know, but there are further design issues that stopped me from doing
it, namely future inheritance when we get to a more generic target
parsing.

Could you please revert your changes on TargetParser until we can all
agree on an implementation that makes sense to the future and present?

cheers,
--renato


More information about the llvm-commits mailing list