[PATCH] D12454: Better lit.cfg "native" detection

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 28 17:21:12 PDT 2015


probinson added a comment.

I got a report that the sanitizer-windows bot failed:
 http://lab.llvm.org:8011/builders/sanitizer-windows/builds/9107
which appears to be due to this patch; thanks for reverting it for me!

The test that failed is in the compiler-rt project, which I don't have checked out.
I guess the problem is a lack of clarity about what "native" target actually means.
We apparently need both kinds of predicate:
(a) host triple == target triple, or more generally: The tools we are building can be used in turn to build programs that can execute on the host; and
(b) host_arch is one of the targets_to_build, which is sufficient for things like llc tests where llc defaults to using the host triple as the target triple, but the output files do not have to execute on the host.

Looking more thoroughly into the history, it appears that "native" was intended to mean (a) from the start, so if we want something that means (b) we'll need to invent it as a new feature.


Repository:
  rL LLVM

http://reviews.llvm.org/D12454





More information about the llvm-commits mailing list