[PATCH] D12153: Support inline functions symbolization in Addr2Line symbolizer.

[Maxim Ostapenko via llvm-commits]

m.ostepenko added a comment.

In http://reviews.llvm.org/D12153#234468, @samsonov wrote:

> Sorry if I'm being overly nitpicky, but I don't understand why you've moved this logic away from Addr2LinePool - I actually preferred when the subclass was responsible for providing correct command to `SendCommand` and parsing its result accordingly...


Ok, I'm moving command modifying logic back to Addr2LinePool. Also, should I move TrimOutputBuffer logic to Addr2LinePool as well? I'm sorry, I'm a bit confused about this stuff.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:226
@@ +225,3 @@
+                      FIRST_32_SECOND_64(UINT32_MAX, UINT64_MAX));
+    command = internal_strncat(command, dummy_address_, kBufferSize);
+  }
----------------
samsonov wrote:
> This is wrong - how could you know if the buffer for `command` has sufficient size?
Hm, I increased command buffer size from 32 to 64, isn't that enough to hold offset + dummy address?

```
 static const uptr kBufferSize = 64;
```


http://reviews.llvm.org/D12153