[PATCH] D12341: add llvm.unpredictable intrinsic and lower it to metadata

[Sanjay Patel via llvm-commits]

spatel added a comment.

Thanks, Krzysztof!

I agree that the existing code in LowerExpectIntrinsic can be improved, but I didn't want to overlap more changes in this patch. How about if I mark them with 'FIXME' comments for now.

I'm also wondering if anyone knows why we have an intrinsic and special lowering for llvm.expect in the first place? Couldn't this be metadata from the start? I looked back at the original commit, but I don't see any discussion/example of the use-case for an intrinsic rather than metadata.


http://reviews.llvm.org/D12341