[PATCH] D11678: [CodeGen] Fixes *absdiff* intrinsic: LangRef doc/test case improvement and corresponding code change

Shahid via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 27 02:03:46 PDT 2015


ashahid added inline comments.

================
Comment at: test/CodeGen/X86/absdiff_128.ll:11-12
@@ +10,4 @@
+; CHECK:      punpckldq
+; CHECK-DAG:  movd   %xmm1, [[SRC:%e[a-d]+x]]
+; CHECK-DAG:  movd   %xmm0, [[DST:%e[a-d]+x]]
+; CHECK:      subl [[SRC]], [[DST]]
----------------
ab wrote:
> The a-d seems too restrictive (what about, say, %r9d?), and '+' seems unnecessary.
Thanks for the input, do you mean to use explicit register name in case of ABI specific register. For example, here if we are expecting EAX & ECX abi registers respectively, I should specify %eax & %ecx?


http://reviews.llvm.org/D11678





More information about the llvm-commits mailing list