[PATCH] D12347: [MC/AsmParser] Avoid setting MCSymbol.IsUsed

Saleem Abdulrasool via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 20:31:23 PDT 2015


compnerd added a comment.

It is unfortunate that these accessors mutate the symbol.  Personally, I think I prefer the alternate approach of a RAII helper that would restore the state.  However, if you are planning some follow up work and this blocks forward progress, then committing this as is to make forward progress would be acceptable (thanks to the annotations).

Thanks for fixing up the test.


http://reviews.llvm.org/D12347





More information about the llvm-commits mailing list