[PATCH] D11434: Allow value forwarding past release fences in EarlyCSE

[JF Bastien via llvm-commits]

jfb added inline comments.

================
Comment at: lib/Transforms/Scalar/EarlyCSE.cpp:617
@@ +616,3 @@
+    // A release fence requires that all stores complete before it, but does
+    // not prevent the reordering of following loads 'before' the fence.  As a
+    // result, we don't need to consider it as writing to memory and don't need
----------------
reames wrote:
> jfb wrote:
> > Getting re-acquainted with the code: it doesn't seem like this change exercises a test?
> Huh?  Not sure what you're asking.  The first two tests in the included file cover cases this triggers.
True, they check that store/fence/load and store/fence/store are handled properly with release.

What I mean is: the code changes, but all of the tests are *exactly the same*. If code changes but tests remains the same, then what changed? :-)


http://reviews.llvm.org/D11434