[PATCH] D11725: [DependenceAnalysis] Ensure All Recurrences are Affine

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 26 12:02:08 PDT 2015


mcrosier added inline comments.

================
Comment at: test/Analysis/DependenceAnalysis/AffineSCEVAddRecExpr.ll:4
@@ +3,3 @@
+;
+; This is a reduced test case from a benchmark in spec2006. We check that this
+; code does not abort.
----------------
Is it valuable to comments this is a reduced test case from spec?  Perhaps we could just say:

"We check that this reduced test case does not abort."

This suggestion doesn't require a revised patch, if accepted.  Just make the change before committing the patch.


http://reviews.llvm.org/D11725





More information about the llvm-commits mailing list