[llvm] r245996 - WebAssembly: add small FIXME for AsmPrinter.

[Rafael Espíndola via llvm-commits]

Please don't do this. It shouldn't be too hard to add logic so that
the asm printer knows there is not .globl.

BTW, does WebAssembly have the notion of a local function? What about
weak? If there is no support for weak, probably the correct thing to
do is error if you ever see a weak GV.

On 25 August 2015 at 20:50, JF Bastien via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: jfb
> Date: Tue Aug 25 19:50:49 2015
> New Revision: 245996
>
> URL: http://llvm.org/viewvc/llvm-project?rev=245996&view=rev
> Log:
> WebAssembly: add small FIXME for AsmPrinter.
>
> Suggested by @sunfish as a follow-up to r245982.
>
> Modified:
>     llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp
>
> Modified: llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp?rev=245996&r1=245995&r2=245996&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp (original)
> +++ llvm/trunk/lib/Target/WebAssembly/MCTargetDesc/WebAssemblyMCAsmInfo.cpp Tue Aug 25 19:50:49 2015
> @@ -52,6 +52,7 @@ WebAssemblyMCAsmInfo::WebAssemblyMCAsmIn
>    // For now, WebAssembly does not support exceptions.
>    ExceptionsType = ExceptionHandling::None;
>
> +  // FIXME: modify AsmPrinter to be more flexible, and fix other virtual ISAs.
>    WeakDirective = "\t;; .weak\t";
>    GlobalDirective = "\t;; .globl\t";
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits