[llvm] r245982 - WebAssembly: comment out .globl when printing textual assembly

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 17:53:03 PDT 2015


On Tue, Aug 25, 2015 at 5:00 PM, Dan Gohman <dan433584 at gmail.com> wrote:
> On Tue, Aug 25, 2015 at 3:23 PM, JF Bastien via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> @@ -52,5 +52,8 @@ WebAssemblyMCAsmInfo::WebAssemblyMCAsmIn
>>    // For now, WebAssembly does not support exceptions.
>>    ExceptionsType = ExceptionHandling::None;
>>
>> +  WeakDirective = "\t;; .weak\t";
>> +  GlobalDirective = "\t;; .globl\t";
>
> Ideally, we should modify the base AsmPrinter class to give us more
> flexibility here, rather than just hacking around it. For now, could
> you add a big FIXME comment about this?

Good point, done in r245996. NVPTX has a similar issue, and I
cargo-culted from it ;-)


More information about the llvm-commits mailing list