[PATCH] D12307: WebAssembly: emit `(func (param t) (result t))` s-expressions

JF Bastien via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 25 15:56:54 PDT 2015


jfb marked an inline comment as done.

================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:145
@@ +144,3 @@
+  raw_svector_ostream OS(Str);
+  OS << ") ;; End func " << toSymbol(CurrentFnSym->getName()) << '\n';
+  OutStreamer->EmitRawText(OS.str());
----------------
sunfishcode wrote:
> This is subjective, but my preference would be to omit this comment, as it adds clutter. If you want to keep it, would you mind making it lower-case?
Lowercased.

I'd like to keep it since functions won't be too frequent compared to the expression trees. At least for early testing it'll make things easier to grok IMO.


http://reviews.llvm.org/D12307





More information about the llvm-commits mailing list