[PATCH] D12001: Implement __emutls_get_address

[Chih-Hung Hsieh via llvm-commits]

chh added inline comments.

================
Comment at: compiler-rt/lib/builtins/emutls.c:41
@@ +40,3 @@
+#if EMUTLS_USE_POSIX_MEMALIGN
+    if (posix_memalign(&base, align, size) != 0)
+        abort();
----------------
danalbert wrote:
> Wow. Phab makes it hard to track comments across versions. This was about `COMPILE_TIME_ASSERT`. Feel free to make your own header in lib/builtins for this. We don't have one for this kind of thing yet.
Done. Added new header comp_assert.h.


================
Comment at: compiler-rt/test/builtins/Unit/emutls_test.c:51
@@ +50,3 @@
+        printf("error in emutls expect true: (%s)\n", #v); \
+        return 1; \
+    } \
----------------
danalbert wrote:
> No sense in continuing a bad thing. This should probably all come out to a shared header at some point.
Done. Added __FILE__ and __LINE__ to printf output.



http://reviews.llvm.org/D12001