[PATCH] D12246: [NVPTX] change threading intrinsics from noduplicate to convergent

Jingyue Wu via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 24 12:09:10 PDT 2015


jingyue added a comment.

Upon further reflection and offline discussion with Xuetian, I think __syncthreads should be marked as convergent instead of noduplicate (see http://lists.llvm.org/pipermail/llvm-dev/2015-August/089525.html). Please shout out if you have any objections.

Not necessarily in this patch, we need to fix other places than JumpThreading, such as SpeculativeExecution, TryToSinkInstruction in InstCombine, and GVN PRE. It's probably fine for now because they don't move instructions with side effects around. But, in the long term, nothing prevents us from having side-effect-free and convergent intrinsics.


http://reviews.llvm.org/D12246





More information about the llvm-commits mailing list