[LNT] r245828 - [lnt] Values for failed tests should be treated as missing.

[Daniel Sanders via llvm-commits]

Author: dsanders
Date: Mon Aug 24 04:04:01 2015
New Revision: 245828

URL: http://llvm.org/viewvc/llvm-project?rev=245828&view=rev
Log:
[lnt] Values for failed tests should be treated as missing.

This includes calculations involving those values such as deltas.

Also, it's not a failure for get_geomean_comparison_result() to have
samples. Pass/failure were inverted in this ComparisonResult but it wasn't
obvious since, prior to this commit, the values were displayed regardless.


Modified:
    lnt/trunk/lnt/server/reporting/analysis.py
    lnt/trunk/lnt/server/ui/templates/v4_run.html

Modified: lnt/trunk/lnt/server/reporting/analysis.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=245828&r1=245827&r2=245828&view=diff
==============================================================================
--- lnt/trunk/lnt/server/reporting/analysis.py (original)
+++ lnt/trunk/lnt/server/reporting/analysis.py Mon Aug 24 04:04:01 2015
@@ -297,7 +297,9 @@ class RunInfo(object):
 
     def get_geomean_comparison_result(self, run, compare_to, field, tests):
         if tests:
-            prev_values,run_values = zip(*[(cr.previous,cr.current) for _,_,cr in tests])
+            prev_values,run_values = zip(
+                *[(cr.previous,cr.current) for _,_,cr in tests
+                  if cr.get_test_status() == UNCHANGED_PASS])
             prev_values = [x for x in prev_values if x is not None]
             run_values = [x for x in run_values if x is not None]
             prev_values = [calc_geomean(prev_values)]
@@ -307,8 +309,8 @@ class RunInfo(object):
 
         
         return ComparisonResult(self.aggregation_fn,
-                                cur_failed=bool(run_values),
-                                prev_failed=bool(prev_values),
+                                cur_failed=not bool(run_values),
+                                prev_failed=not bool(prev_values),
                                 samples=run_values,
                                 prev_samples=prev_values,
                                 confidence_lv=0,

Modified: lnt/trunk/lnt/server/ui/templates/v4_run.html
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/ui/templates/v4_run.html?rev=245828&r1=245827&r2=245828&view=diff
==============================================================================
--- lnt/trunk/lnt/server/ui/templates/v4_run.html (original)
+++ lnt/trunk/lnt/server/ui/templates/v4_run.html Mon Aug 24 04:04:01 2015
@@ -29,9 +29,11 @@
   {% set test_status = cr.get_test_status() %}
   {% set value_status = cr.get_value_status(ignore_small=not options.show_small_diff) %}
   {% set run_cell_value = "-" if cr.current is none else "%.4f" % cr.current %}
+  {% set run_cell_value = "-" if test_status in [analysis.REGRESSED, analysis.UNCHANGED_FAIL] else run_cell_value %}
 
   {% if options.show_previous %}
     {% set prev_cell_value = "-" if cr.previous is none else "%.4f" % cr.previous %}
+    {% set prev_cell_value = "-" if test_status in [analysis.IMPROVED, analysis.UNCHANGED_FAIL] else prev_cell_value %}
     <td>{{prev_cell_value}}</td>
   {% endif %}
 
@@ -50,7 +52,8 @@
     <td>{{run_cell_value}}</td>
   {% endif %}
 
-  {% if (options.show_all or
+  {% if test_status == analysis.UNCHANGED_PASS and
+        (options.show_all or
          value_status == analysis.REGRESSED or
          value_status == analysis.IMPROVED) %}
     {{ cr.pct_delta|aspctcell(reverse=cr.bigger_is_better)|safe }}
@@ -59,13 +62,13 @@
   {% endif %}
 
   {% if options.show_delta %}
-    <td>{{ "-" if cr.delta is none else "%.4f" % cr.delta }}</td>
+    <td>{{ "-" if cr.delta is none or test_status != analysis.UNCHANGED_PASS else "%.4f" % cr.delta }}</td>
   {% endif %}
   {% if options.show_stddev %}
-    <td>{{ "-" if cr.stddev is none else "%.4f" % cr.stddev }}</td>
+    <td>{{ "-" if cr.stddev is none or test_status != analysis.UNCHANGED_PASS  else "%.4f" % cr.stddev }}</td>
   {% endif %}
   {% if options.show_mad %}
-    <td>{{ "-" if cr.MAD is none else "%.4f" % cr.MAD }}</td>
+    <td>{{ "-" if cr.MAD is none or test_status != analysis.UNCHANGED_PASS  else "%.4f" % cr.MAD }}</td>
   {% endif %}
   {% if options.show_all_samples %}
     <td>