[PATCH] D11885: AMDGPU/SI: Add SI Machine Scheduler

Axel Davy via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 21 14:14:15 PDT 2015


axeldavy added inline comments.

================
Comment at: lib/Target/AMDGPU/SIMachineScheduler.cpp:640
@@ +639,3 @@
+// Both TopDown and BottomUp
+void SIScheduleDAGMI::topologicalSort() {
+  unsigned DAGSize = SUnits.size();
----------------
tstellarAMD wrote:
> This function seems to have parts that where copied from ScheduleDAGTopologicalSort::InitDAGTopologicalSorting() in ScheduleDAG.cpp.  Is there some reason why we can't just re-use that function?
The function couldn't be reused in particular because it was doing only TopDown (here both TopDown and BottomUp were needed).


http://reviews.llvm.org/D11885





More information about the llvm-commits mailing list