[PATCH] D12219: WebAssembly: Implement call

[JF Bastien via llvm-commits]

jfb added inline comments.

================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:136
@@ +135,3 @@
+    case MachineOperand::MO_GlobalAddress: {
+      OS << " `" << MO.getGlobal()->getName();
+    } break;
----------------
sunfish wrote:
> Is this a mismatched quote?
Nah, just a marker for symbols. The discussion was still ongoing, but it looks like things settled on `$` instead.
I'll factor it out into a `toSymbol` function.

================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrCall.td:22
@@ +21,3 @@
+             [(WebAssemblycallseq_end timm:$amt1, timm:$amt2)],
+	     "#ADJCALLSTACKUP $amt1 $amt2">;
+
----------------
sunfish wrote:
> If we're going to use Pseudo instructions, should implement expandPostRAPseudo to expand them.
BPF doesn't have it and aarch64 ignores `callseq` in `expandPostRAPseudo`, but both use pseudos. I'm not sure I understand what our current implementation would do beyond returning `false`, but then again I'm still pretty confused by selection DAG. Do you think this patch should have `expandPostRAPseudo`, and if so in what form?


http://reviews.llvm.org/D12219