[PATCH] D12132: TransformUtils: Introduce module splitter.

Pete Cooper via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 22:34:23 PDT 2015


Sorry to chime in late on this.  I missed this patch go by.

> On Aug 18, 2015, at 7:57 PM, Peter Collingbourne via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> This initial version of the splitter does not attempt to deal with the
> somewhat subtle symbol visibility issues around module splitting. These
> will be dealt with in a future change.
So I believe Lang (CCed) has implemented much of whats needed for symbol visibility in the OrcJIT (see CompileOnDemandLayer.h).

I think it would make sense to share as much of that code between these implementations.  In particular, code to work out new linkage types should be common.  Code to create new globals would be a bonus to share too in cases where we need to clone globals too.

Cheers,
Pete

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20150820/09e698c2/attachment.html>


More information about the llvm-commits mailing list