[PATCH] D12132: TransformUtils: Introduce module splitter.

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 20 12:22:53 PDT 2015


pcc added inline comments.

================
Comment at: lib/Transforms/Utils/CloneModule.cpp:94
@@ +93,3 @@
+      // kinds of globals is forbidden), but this is generally not required for
+      // correctness.
+      continue;
----------------
I spoke too soon. Looks like aliases can be thread-local, and their thread-localness is a property of the alias rather than being inherited from the aliasee. That seems really bizarre. But in any case we are copying the thread-local property from the alias, so we are fine as far as thread-localness goes.


http://reviews.llvm.org/D12132





More information about the llvm-commits mailing list