[PATCH] D11313: [ValueTracking] computeOverflowForSignedAdd and isKnownNonNegative

[Philip Reames via llvm-commits]

reames added inline comments.

================
Comment at: lib/Analysis/ValueTracking.cpp:3327
@@ -3318,1 +3326,3 @@
 
+static OverflowResult computeOverflowForSignedAdd(
+    Value *LHS, Value *RHS, Value *Add, const DataLayout &DL,
----------------
majnemer wrote:
> This seems to overlap with `InstCombiner::WillNotOverflowSignedAdd`, would it make sense to consolidate this with that?
Didn't know we had that one.  Yes, a follow up patch to consolidate would make great sense.  


http://reviews.llvm.org/D11313